C2 (macro)elements#212
Conversation
f5e3fb8 to
0d524a9
Compare
aa44c17 to
786eb6c
Compare
937b65c to
b6f1919
Compare
730037b to
f28b62c
Compare
9351c3b to
14e0c9b
Compare
rckirby
left a comment
There was a problem hiding this comment.
I'm a bit uneasy about not having math yet, but that can be fixed. The main concern about merging is getting a slightly more descriptive name for the element like C2DoubleAlfeld. Other suggestions welcome.
| # Inverse mapping | ||
| imapping = {v: k for k, v in mapping.items()} | ||
|
|
||
| Jnp = numpy.asarray([[J[i, j] for j in range(sd)] for i in range(sd)]) |
There was a problem hiding this comment.
I appreciate the generality here. However, the math + numpy is a bit unclear. For example, how does this go from the 2x2 jet to 3x3 Hessian map (often called Theta) in the zany papers? Maybe a comment is in order.
There was a problem hiding this comment.
I guess if we write out the maths in a paper this will all become clearer to me?
7775dcc to
f7d1b6a
Compare
rckirby
left a comment
There was a problem hiding this comment.
I think I'm ok with this once we land on the final version of the names. Once The Paper is written on the transformations, we can link to it and the mysterious code will be at least documented on the arXiv.
| # Inverse mapping | ||
| imapping = {v: k for k, v in mapping.items()} | ||
|
|
||
| Jnp = numpy.asarray([[J[i, j] for j in range(sd)] for i in range(sd)]) |
There was a problem hiding this comment.
I guess if we write out the maths in a paper this will all become clearer to me?
Adds the Bramble-Zlanial C2 element (degree >= 9) and the Alfeld C2 macroelement on a double Alfeld split (degree >= 5).